Skip to content

Play 8

Raphael Mäder requested to merge PLAY-8 into master

Created by: sunsetter

  • PLAY-8 change the approach to interact with entityManager and jpaApi The calls to entityManager(.em()) was changes from jpaApi to JPA because written test functionality seen to us how the jpaApi interact with it whenever to be usefull to use the standart helper class(according to play docs)

  • PLAY-8 modify MString functional test to communicate with fake application according to best play practises

  • PLAY-8 modify MString test use a fake guice application to inject all dependencies in fake app\nThe MString encapsulate a lot of injected internal elements such as translations, languages f.e. So, reasonably to create a fake application which triggers all dependencies and creates in memory database, but in fact, the entity manager can't be loaded for unknown. There is the outter entityManager uses the same configuration and delegate persistence to himself

  • PLAY-8 add database tests

  • PLAY-8 Add draft test for AccessControlListVoter

  • PLAY-8 Extract permission enums search packages list into a constructor parameter of DefaultPermissionManager

    The packages list for reflective types scanner was hardcoded into DefaultPermissionManager#findDomainPermissionEnums which was not flexible and hard to test. For backward compatibility the hardcoded packages list was moved to the default injected constructor.

  • PLAY-8 Add mockito dependency to play-auth and play-commons

  • PLAY-8 Remove redundant public, static, final modifiers of interface inner classes

  • PLAY-8 Add method PermissionManager#definePermission(TypedDomainPermission) for convenience

  • PLAY-8 Remove redundant definePermission overloaded method

  • PLAY-8 Add PermissonManagerTest

  • PLAY-8 Extract AccessControlList interface

    Splitting AccessControlList into implementation and interface adds more flexibility for unit test and API users.

  • PLAY-8 Remove direct dependency to static members of ch.insign.PlayAuth at DefaultAccessControlListVoter

    Inject SecurityIdentityRetrievalStrategy and ObjectIdentityRetrievalStrategy instead of directly accessing PlayAuth.getSecurityIdentity/getObjectIdentity

  • PLAY-8 Add mocks

    • AccessControlListMock
    • PermisionManagerProviderMock

  • PLAY-8 Improve authz tests

    • add initial code to ACL voter test
    • refactor PermissionManagerTest

  • PLAY-8 HotFix compilation error

  • PLAY-8 HotFix compilation error

  • PLAY-21 Improve ACL test & fix found issues in play-auth

  • PLAY-8, PLAY-44 Fix DefaultObjectIdentityRetrievalStrategy to properly handle lambdas & anonymous classes

  • PLAY-8, PLAY-44 Fix acl/aclv use in tests

  • PLAY-8, PLAY-44 Remove direct dependency to global context in DefaultAccessControlListVoter

  • PLAY-44 Get rid of using PermissionManager inside AccessControlEntry bean.

  • PLAY-44 Get rid of using PermissionManager inside AccessControlEntry bean.

Merge request reports